Handle expressions not representable by SymPy#254
Open
hrueter wants to merge 1 commit intoMathics3:masterfrom
Open
Handle expressions not representable by SymPy#254hrueter wants to merge 1 commit intoMathics3:masterfrom
hrueter wants to merge 1 commit intoMathics3:masterfrom
Conversation
Contributor
|
@hrueter, could you some examples in which this change has an impact? |
Member
Even better would be to add a test. |
rocky
force-pushed
the
master
branch
4 times, most recently
from
71081e7 to
93ed59e
Compare
Contributor
|
@hreuter, is this PR still valid? |
Contributor
Author
You got my github handle wrong. ;-) I will check whether this is still relevant. But first some new bugs have to be fixed, so that I can run my old test problem again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deals with some cases where it is safe to return the expression, when it cannot be handled by SymPy.